-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: GitHub Actions add Windows to the testing #1996
Conversation
@joaocgreis This might be of interest to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows test still failed
Yes. I am not a Windows guy and I do not understand how to fix test_BinaryNamesWindows() |
@cclauss isn't this similar to what happened in Travis, the VS version is more recent than the one supported by our gyp version? If this is the case, a good way to fix is to set the MSVS variables similarly to Travis: Line 106 in 5a729e8
|
@joaocgreis Using shell: bash along with your suggestion enables the Windows tests to pass. Thanks much! |
PR-URL: #1996 Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@joaocgreis This might be of interest to you.
Checklist
npm install && npm test
passesDescription of change