-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc, bin: stop suggesting opening node-gyp issues #2096
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -131,9 +131,8 @@ function errorMessage () { | |
|
||
function issueMessage () { | ||
errorMessage() | ||
log.error('', ['This is a bug in `node-gyp`.', | ||
'Try to update node-gyp and file an Issue if it does not help:', | ||
' <https://github.com/nodejs/node-gyp/issues>' | ||
log.error('', ['Node-gyp failed to build your package.', | ||
'Try to update node-gyp and if it does not help file an issue with the package author' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "update node-gyp" is no trivial matter though, I think this was written even before it was bundled with npm. Maybe we should say "Try to update npm and/or node-gyp" or something along those lines? I don't think we can fit in explanations of how to make npm use an external node-gyp in this message and that's not necessarily good practice anyway. |
||
].join('\n')) | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we talk about three backticks on a line by themselves above the first line of the log and the same below the last line of the log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope that people will just overwrite the example output, not paying to much attention to the backticks. We can add one more extra line here to make it easier for users to use backticks correctly.