-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: replace depracted set-env with github envs #2261
Conversation
Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell? |
Since we don't override the default I believe actions on Windows run in powershell by default: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell |
Co-authored-by: Richard Lau <rlau@redhat.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
I think I find the right way in #2285, can you cherrypick it here ? |
Well you got it working in that one, let's just close this one and go with yours :) |
Ok, I find the other part is still useful, I will try to import to my patch. Thanks for taking time on this :)
Yeap, github documentation is useless in this case. I searched lots of code find this out. |
Fixes #2231
Checklist
npm install && npm test
passesDescription of change
set-env is deprecated and builds will fail, this should fix it