Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a Python lint error by using an f-string #2886

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix: a Python lint error by using an f-string #2886

merged 1 commit into from
Jul 20, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 17, 2023

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@richardlau
Copy link
Member

This should be upstreamed in gyp-next otherwise it will be overwritten the next time gyp-next it is updated here.

@cclauss cclauss mentioned this pull request Jul 17, 2023
Merged
@cclauss cclauss requested a review from richardlau July 17, 2023 18:13
cclauss added a commit that referenced this pull request Jul 17, 2023
@cclauss
Pickup lint fix from #2886
2e3b303
@cclauss cclauss mentioned this pull request Jul 19, 2023
Merged
2 tasks
@cclauss
Copy link
Contributor Author

cclauss commented Jul 20, 2023

Upstreamed in

@cclauss cclauss merged commit 1bfb083 into main Jul 20, 2023
@cclauss cclauss deleted the Fix-Python-lint-error-by-using-an-f-string branch July 20, 2023 13:04
lukekarrys pushed a commit that referenced this pull request Oct 27, 2023
@cclauss @lukekarrys
Fix Python lint error by using an f-string (#2886)
4285735
lukekarrys pushed a commit that referenced this pull request Oct 27, 2023
@cclauss @lukekarrys
Fix Python lint error by using an f-string (#2886)
c067d2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@StefanStojanovic StefanStojanovic Awaiting requested review from StefanStojanovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @richardlau