Avoid copying around node.lib on Windows #537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imagine a Jenkins build server, where node-gyp chooses a dev dir of say `C:\Users\jenkins\.node-gyp\0.10.29\`. The build server runs multiple build jobs in parallel, each with disjoint working directories, but sharing global state such as the node-gyp dev dir. Some of these build jobs are using node-gyp to build 32-bit binaries, and some are using node-gyp to build 64-bit binaries. Sometimes the following scenario could previously occur: 1. Job A step 1: Copy `C:\Users\jenkins\.node-gyp\0.10.29\ia32\node.lib` to `C:\Users\jenkins\.node-gyp\0.10.29\Release\node.lib` 2. Job B step 1: Copy `C:\Users\jenkins\.node-gyp\0.10.29\x64\node.lib` to `C:\Users\jenkins\.node-gyp\0.10.29\Release\node.lib` 3. Job B step 2: Successfully build and link a 64-bit binary. 4. Job A step 2: Attempt to build and link a 32-bit binary, but fail because `C:\Users\jenkins\.node-gyp\0.10.29\Release\node.lib` is of the wrong architecture. This commit avoids the above scenario by making the dev dir immutable, and making the generated vcxproj files refer directly to the node.lib file for the appropriate architecture.
|
How would that work when compiling for both Would adding |
|
I'll close, there are fresher pull requests that address this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagine a Jenkins build server, where node-gyp chooses a dev dir of say
C:\Users\jenkins\.node-gyp\0.10.29\. The build server runs multiple build jobs in parallel, each with disjoint working directories, but sharing global state such as the node-gyp dev dir. Some of these build jobs are using node-gyp to build 32-bit binaries, and some are using node-gyp to build 64-bit binaries. Sometimes the following scenario could previously occur:C:\Users\jenkins\.node-gyp\0.10.29\ia32\node.libtoC:\Users\jenkins\.node-gyp\0.10.29\Release\node.libC:\Users\jenkins\.node-gyp\0.10.29\x64\node.libtoC:\Users\jenkins\.node-gyp\0.10.29\Release\node.libC:\Users\jenkins\.node-gyp\0.10.29\Release\node.libis of the wrong architecture.This commit avoids the above scenario by making the dev dir immutable, and making the generated vcxproj files refer directly to the node.lib file for the appropriate architecture.
This is rather similar to #443 / #450.