Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing ansi path related issues #672

Closed
wants to merge 1 commit into from
Closed

fixing ansi path related issues #672

wants to merge 1 commit into from

Conversation

Chudesnov
Copy link

As I've already mentioned, paths passed to vcbuild/msbuild are still encoded incorrectly on non-Latin editions of Windows. Here's a more flexible solution that, hopefully, will fix ANSI→UTF encoding issues on Windows 2000 and higher.

Fixes: #297

@Sogl
Copy link

Sogl commented Jul 28, 2015

👍

@bnoordhuis
Copy link
Member

Is this still an issue? The patch should be sent to the upstream gyp project but I'll be happy to cherry-pick it once it lands.

@Chudesnov
Copy link
Author

Yes, it is.

No problem, I'll submit a pull request to bnoordhuis/gyp when I get home.

@bnoordhuis
Copy link
Member

I'm not the upstream, https://code.google.com/p/gyp is. :-)

Sending patches to Google projects is kind of hassle (need to check out depot_tools, upload patch with git-cl) but I'll be happy to walk you through it if you get stuck. Please post the link to the CL in the issue when you're done so we can track it.

@Chudesnov
Copy link
Author

It seems that depot_tools and gclient in particular suffer from the very same bug - incorrectly re-encoding ansi paths into unicode. Gonna try to fix that as well :)

@roman-yerin
Copy link

@Chudesnov any chance to fix it in upstream?

@bnoordhuis
Copy link
Member

Seeing how there has been no follow-up, I'll go ahead and close this.

@bnoordhuis bnoordhuis closed this Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with non-acsii userprofile name on Windows (7)
4 participants