Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: command options aren't documented #879

Closed
wants to merge 1 commit into from

Conversation

hintjens
Copy link

Especially the --jobs and logging options are valuable and deserve to
be documented.

Solution: add 'Command options' section to README.md.

Note: I also added a -silent option to switch off all logging, for
consistency with the other logging options.

Especially the --jobs and logging options are valuable and deserve to
be documented.

Solution: add 'Command options' section to README.md.

Note: I also added a -silent option to switch off all logging, for
consistency with the other logging options.
@bnoordhuis
Copy link
Member

Can you break this into two commits? Extra karma if you add a small regression test for the --silent switch.

@hintjens
Copy link
Author

I can redo this, sure, and try to add a regression test. Do you mind if I push multiple commits into a single PR? Or do you prefer branches for each commit?

@hintjens hintjens closed this Feb 14, 2016
@bnoordhuis
Copy link
Member

Multiple commits are fine. You don't need to file a new PR, you can force-push to your branch and it'll show up here (but please leave a comment when you do, GH doesn't send notifications for that.)

@hintjens
Copy link
Author

:-) great, will do.

@hintjens
Copy link
Author

@bnoordhuis turns out github wanted me to make a new PR, which I did: #880

I've also added a new option, --mklocal to work around a bug in gyp that has been causing grief. It seems a rather major issue in gyp, yet I can't find it in the issue tracker before now. See https://bugs.chromium.org/p/gyp/issues/detail?id=508. I guess few people are mixing --generator-output with gyp dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants