Add --devdir flag. #916
Merged
Add --devdir flag. #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Obsoletes #540. |
|
lgtm |
Overrides the location where node-gyp will look for (and download to) the node.js SDK. For harmonization with the --nodedir flag, `osenv.home()` is now used instead of `process.env.HOME || process.env.USERPROFILE`. `osenv.home()` defaults to the built-in `os.homedir()` when available and falls back to sane defaults based on the platform. `%USERPROFILE%` is now preferred on Windows and `%HOME%` is ignored; similarly, UNIX systems ignore `$USERPROFILE` from now on. Neither behavior made much sense, IMO. Fixes: #21 PR-URL: #916 Reviewed-By: Rod Vagg <rod@vagg.org>
|
Great work here, @bnoordhuis! Thank you so much! ✨ Is there an ETA for the next node-gyp release that will contain this change? We would like to stop using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides the location where node-gyp will look for (and download to)
the node.js SDK.
For harmonization with the --nodedir flag,
osenv.home()is now usedinstead of
process.env.HOME || process.env.USERPROFILE.osenv.home()defaults to the built-inos.homedir()when availableand falls back to sane defaults based on the platform.
%USERPROFILE%is now preferred on Windows and%HOME%is ignored;similarly, UNIX systems ignore
$USERPROFILEfrom now on. Neitherbehavior made much sense, IMO.
Fixes: #21