Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimatch #961

Closed
wants to merge 1 commit into from
Closed

Update minimatch #961

wants to merge 1 commit into from

Conversation

delphiactual
Copy link
Contributor

No description provided.

@rvagg
Copy link
Member

rvagg commented Jun 18, 2016

thanks @delphiactual, do you have any context to share here, what might have changed and/or broken between 1 & 3 that we might need to look out for?

@delphiactual
Copy link
Contributor Author

delphiactual commented Jun 19, 2016

Latest commit which brought him up to 3.0.2 fixes a DoS that can occur in older versions. Whether anything else changed between 1 & 3 I have no idea. Maybe @isaacs can give you more info.

@rvagg
Copy link
Member

rvagg commented Jun 20, 2016

Yeah, I've just had a cruise through some of the changes and it doesn't seem to be anything major other than style, removal of internal caching and other bits and pieces that I can't see impacting on our minimal usage: minimatch(file, '*.h', { matchBase: true }) and minimatch(file, '*.gypi', { matchBase: true }).

This lgtm. Anyone else?

@rvagg
Copy link
Member

rvagg commented Jun 27, 2016

merged, thanks @delphiactual

@rvagg rvagg closed this Jun 27, 2016
rvagg pushed a commit that referenced this pull request Jun 28, 2016
PR-URL: #961
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants