-
Notifications
You must be signed in to change notification settings - Fork 45
illegal hardware exception #6
Comments
Its fairly reproduceable. I ran with gdb, too:
|
Yes, nodereport sets --abort_on_uncaught_exception, and uses |
I think normal node behaviour should be the default, yes. If people want abort on uncaught exception, they can set that flag on the command line. But... it sounds like the mechanism you are using won't allow that. Have you considered using I'm pretty surprised node aborts with an illegal instruction and not |
This still needs more work:
|
We replace Node.js' |
There is a complicated story behind ShouldAbortOnUncaughtException() in node.cc, see: The logic was added to fix behaviour when domains are used. It prevents the --abort-on-uncaught-exception option from triggering an abort when domains are used to catch errors. In practice, domains are deprecated, and the call to TopDomainHasErrorHandler(env) has a simple check, which means that the logic is a no-op now:
So I've simply omitted that code in the node-report callback |
@sam-github latest node-report v2.1.2 has the fix to the exception handler, and the improved demos, hopefully we can close this now |
Is this expected?
System info:
I got this when I was trying to verify whether nodereport after reporting an uncaught exception, would let the exception continue to propagate and cause node to exit (as it should).
The text was updated successfully, but these errors were encountered: