-
Notifications
You must be signed in to change notification settings - Fork 45
nit? s/nodereport/node-report #35
Comments
I think if we're going to change it the earlier the better. |
https://www.npmjs.com/package/node-report Is already taken. |
/cc @chirag04 |
i'm not using happy to transfer. |
Thanks @chirag04, node-report would be a better name for this project and module |
Provided we can get the name in the appropriate places +1 from me. |
I added @rnchamberlain as the owner. Feel to claim it. let me know if i can do anything else to help here. |
We're due a semver-major bump for #25 -- Would seem the ideal time to do the rename (if it's not going to take long). |
@richardlau agree re #25, but I also have a fix coming up for #6 which changes nodereport behaviour and I'd like to release that at the same time. Currently nodereport is at v1.0.7 and node-report is v0.1.0. Would we move node-report to v1.0.0? |
@rnchamberlain It's probably worth creating a github milestone for the next major release. +1 to |
#37 handles renaming in the source code. Who can rename this repository? |
According to https://help.github.com/articles/renaming-a-repository/ someone with the powers will have a gear wheel/settings tab showing on the main repo page https://github.com/nodejs/nodereport. I'm not seeing that myself. |
Looking at the list of Org |
Suggested steps required, in sequence:
Prior to this change, the report files produced were named NodeReport.<date>.<time>.<pid>.<seq>.txt. From version 2.0.0 report filenames are node-report.<date>.<time>.<pid>.<seq>.txt |
node-report v2.0.0 now published on https://www.npmjs.com/package/node-report for changes see https://github.com/nodejs/node-report/blob/master/CHANGES.md |
node-report (formerly nodereport) has been renamed, see nodejs/node-report#35 (comment).
node-report (formerly nodereport) has been renamed, see nodejs/node-report#35 (comment).
All done now I think, new git repo is https://github.com/nodejs/node-report, new package is https://www.npmjs.com/package/node-report. Added message in old package README and npm deprecate warning on nodereport. |
I think
node-report
is closer to our typical conventions thannodereport
, plus it fits nicely with node-inspect, node-heapdump, node-profiler etc. Do you think it would be worth changing the name of the repo, module, etc.? Certainly the sooner the better if we're going to do that.Personally I think we should change it, I can even put it on my own backlog if others agree.
The text was updated successfully, but these errors were encountered: