Skip to content
This repository has been archived by the owner on Jun 18, 2021. It is now read-only.

nit? s/nodereport/node-report #35

Closed
joshgav opened this issue Jan 4, 2017 · 16 comments
Closed

nit? s/nodereport/node-report #35

joshgav opened this issue Jan 4, 2017 · 16 comments

Comments

@joshgav
Copy link

joshgav commented Jan 4, 2017

I think node-report is closer to our typical conventions than nodereport, plus it fits nicely with node-inspect, node-heapdump, node-profiler etc. Do you think it would be worth changing the name of the repo, module, etc.? Certainly the sooner the better if we're going to do that.

Personally I think we should change it, I can even put it on my own backlog if others agree.

@gibfahn
Copy link
Member

gibfahn commented Jan 4, 2017

I think if we're going to change it the earlier the better.

@richardlau
Copy link
Member

https://www.npmjs.com/package/node-report Is already taken.

@williamkapke
Copy link

/cc @chirag04

@chirag04
Copy link

chirag04 commented Jan 4, 2017

i'm not using node-report and seems like nobody else is. i don't even remember if node-report is actually doing anything meaningful.

happy to transfer.

@rnchamberlain
Copy link
Contributor

Thanks @chirag04, node-report would be a better name for this project and module

@mhdawson
Copy link
Member

mhdawson commented Jan 5, 2017

Provided we can get the name in the appropriate places +1 from me.

@chirag04
Copy link

chirag04 commented Jan 5, 2017

I added @rnchamberlain as the owner. Feel to claim it. let me know if i can do anything else to help here.

@richardlau
Copy link
Member

We're due a semver-major bump for #25 -- Would seem the ideal time to do the rename (if it's not going to take long).

@rnchamberlain
Copy link
Contributor

@richardlau agree re #25, but I also have a fix coming up for #6 which changes nodereport behaviour and I'd like to release that at the same time.

Currently nodereport is at v1.0.7 and node-report is v0.1.0. Would we move node-report to v1.0.0?

@gibfahn
Copy link
Member

gibfahn commented Jan 10, 2017

@rnchamberlain It's probably worth creating a github milestone for the next major release.

+1 to v2.0.0

@richardlau
Copy link
Member

#37 handles renaming in the source code.

Who can rename this repository?

@rnchamberlain
Copy link
Contributor

According to https://help.github.com/articles/renaming-a-repository/ someone with the powers will have a gear wheel/settings tab showing on the main repo page https://github.com/nodejs/nodereport. I'm not seeing that myself.

@williamkapke
Copy link

Looking at the list of Org owners that have also been somewhat involved in this group... let's ping @mhdawson and maybe @Fishrock123

@rnchamberlain
Copy link
Contributor

rnchamberlain commented Jan 20, 2017

Suggested steps required, in sequence:

  1. Rename this repo to github.com/nodejs/node-report - done

  2. Update the module code, readme, tests and demos to use the new "node-report" name where appropriate, see Rename nodereport module to node-report #52 - done

  3. Version as v2.0.0 and release on https://www.npmjs.com/package/node-report - done

  4. Update the readme on https://www.npmjs.com/package/nodereport to say it's obsolete, and reference the new one. For npm to publish the updated readme we'll need a package.json increment to v1.0.8 on there. - done

  5. Run npm deprecate on the old package so that users get a warning message when they install it - done

Prior to this change, the report files produced were named NodeReport.<date>.<time>.<pid>.<seq>.txt. From version 2.0.0 report filenames are node-report.<date>.<time>.<pid>.<seq>.txt

@rnchamberlain
Copy link
Contributor

node-report v2.0.0 now published on https://www.npmjs.com/package/node-report

for changes see https://github.com/nodejs/node-report/blob/master/CHANGES.md

richardlau added a commit to richardlau/TSC that referenced this issue Feb 9, 2017
node-report (formerly nodereport) has been renamed, see nodejs/node-report#35 (comment).
jasnell pushed a commit to nodejs/TSC that referenced this issue Feb 9, 2017
node-report (formerly nodereport) has been renamed, see nodejs/node-report#35 (comment).
@rnchamberlain
Copy link
Contributor

All done now I think, new git repo is https://github.com/nodejs/node-report, new package is https://www.npmjs.com/package/node-report.

Added message in old package README and npm deprecate warning on nodereport.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants