This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
Fix for clang warning: libstdc++ is deprecated #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing on macOS 10.12 (Sierra), the deprecation warning above is output. The fix is to override the std c++ library so that the module is linked to libc++
Closed
|
Seems to fix #32 |
richardlau
approved these changes
Dec 13, 2016
gdams
approved these changes
Dec 16, 2016
rnchamberlain
added a commit
that referenced
this pull request
Dec 16, 2016
When installing on macOS 10.12 (Sierra), the deprecation warning above is output. The fix is to override the std c++ library so that the module is linked to libc++ PR-URL: #31 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gib@uk.ibm.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
|
Landed as 67050f5 |
This was referenced Feb 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing the nodereport module on macOS 10.12 (Sierra), the clang deprecation warning above is output during npm install. The fix is to override the std c++ library inherited from node, so that the module is linked to libc++
Uses known solution described here: nodejs/nan#606
Fixes #22