Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

64bit binary in the OS X installer. Still installs on 32bit machines. #2770

Closed
pygy opened this issue Feb 17, 2012 · 2 comments
Closed

64bit binary in the OS X installer. Still installs on 32bit machines. #2770

pygy opened this issue Feb 17, 2012 · 2 comments
Labels
installer macintosh

Comments

@pygy
Copy link

pygy commented Feb 17, 2012

It would be nice if the OS X installer performed a CPU architecture check.
@bnoordhuis
Copy link
Member

@isaacs: The node binary is i386 in node-v0.7.3.pkg but it's x86_64 in node-v0.6.10.pkg. Is that intentional?

On a general note, we should probably ship universal binaries, larger file sizes be damned.

@isaacs
Copy link

isaacs commented Feb 17, 2012

Hm. Looks like the make pkg target in os x doesn't force the arch to ia32. It ought to. (Already does this on master.)

@bnoordhuis Yes, we should ship universals. But for now (that is, 0.6.11) it's probably best to just make it i386

@isaacs isaacs closed this as completed in e16c6c7 Feb 17, 2012
bnoordhuis pushed a commit to bnoordhuis/node that referenced this issue Feb 17, 2012
@isaacs
Fix nodejs#2770 Compile the OS X pkg as ia32
4672872
@thepatrick thepatrick mentioned this issue Feb 23, 2012
Closed
@Django0505 Django0505 mentioned this issue Nov 30, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
installer macintosh
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@isaacs @pygy @bnoordhuis