Large file uploads getting data lost and never finishing over HTTPS in 0.10.0

[geoffreak]

All code referenced in this issue can be found in this gist.

I've found an issue with HTTPS servers where large file uploads have data lost (if not used right away). I tested a 8MB text file that contained This is a testfile! repeated excessively.

In the example code, the only difference between httpsServerFail and httpServerSuccess is that they use the https vs http modules, yet only the non-HTTPS version will receive all the data from a file. My 8MB test file would only end up creating a file on the server that was around 140-160KB in addition to never causing an end event. Files that are only a few KB in size have no issues. Remember that no such issues exist with HTTP servers.

In the example code, a successful upload should have the server print the following:

data
timeout
end

Whereas an unsuccessful upload will only print the following (and hang the client)

data
timeout

To simplify things in the clients, I used the request module, but I verified that it wasn't the cause by also running the following curl requests via the terminal that produced identical results.

curl https://localhost:8091 -X PUT -T testfile.txt  -k
curl http://localhost:8091 -X PUT -T testfile.txt 

[isaacs]

@indutny would you like to look into this? Sounds like the CryptoStream is locking up at some point?

[indutny]

Sure.

[indutny]

For tomorrow me - this might be related to this https://github.com/joyent/node/blob/master/lib/tls.js#L316 , considering comment about 160 kb of incoming data. Though, I haven't looked really deep yet.

[indutny]

See #5034

[indutny]

Can you please verify that your test works with my fix?

[geoffreak]

Sure, I'm trying to figure out how run your modified version of Node now.

[indutny]

Just checkout this branch, run "./configure && make -j4 && ./node server.js" and test it with curl or whatever.

[geoffreak]

Okay, it appears to be working. I see the end on the server, the client finishes, and the uploaded file is the full size. I tested against this branch.

[indutny]

Fixed in 14a8fb8.

[indutny]

Ouch... that should be landed in 0.10 too.

[indutny]

And b5ddc0c in 0.10