HTTP end event not fired

[azcoffeehabit]

After upgrade to 10.8 http end events are not fired (was working in 8.x). See following code:

var http = require("http");
var port = 8888;

function startServer(route, handle) {
    function onRequest(request, response) {
        console.log("Request received.");

        request.setEncoding("utf8");

        if(request.method == 'POST') {
            request.addListener("data", function(postDataChunk) {
                console.log("Received POST data chunk '"+ postDataChunk + "'.");
            }); 
        }
        else {
            console.log(request.method + " request received");
        }

        request.on('end', function () {
            console.log("end request received");
        });

        request.on('error', function () {
            console.log("There was an error event");
        });
    }

    var server = http.createServer(onRequest).listen(port);
}
startServer();

TESTS

test 1: standard GET request

$ curl localhost:8888

console:
Request received.
GET request received

test 2: standard POST with data

$ curl localhost:8888 -d 'test'

console:
Request received.
Received POST data chunk 'test'.
end request received

test 3: GET with data

$ curl localhost:8888 -G -d 'test'

node console:
Request received.
GET request received

[tjfontaine]

This is working as expected, it's a by product of the streams2 work the stream won't start reading until you tell it to. You initiate reading by:

• piping the stream somewhere req.pipe()
• resuming the stream req.resume()
• switching into old mode req.on('data')

In your example you're only switching into old mode when it's a POST

[azcoffeehabit]

Thank you so much. Makes perfect sense now!