Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Force header not to be set with node.http.Client get() #8

Closed
Connorhd opened this issue Jun 6, 2009 · 3 comments
Closed

Force header not to be set with node.http.Client get() #8

Connorhd opened this issue Jun 6, 2009 · 3 comments

Comments

@Connorhd
Copy link

Connorhd commented Jun 6, 2009

Currently if you don't set Transfer-Encoding or Content-Length then Transfer-Encoding gets set to chunked, it would be nice if I could set Transfer-Encoding to null or similar to force it not to be set.

While I was playing with this I also noticed if you set Content-Length-Something it matches Content-Length as being set, probably not going to cause any problems but not sure if there could be better behaviour?

@ry
Copy link

ry commented Jun 6, 2009

Set the content-length header and you'll get an identity transfer encoding. Probably could be better behavior - I'm open to suggestions. This code btw is in pure javascript in src/http.js.

But as far as I can see, this is not a bug? re-open if i'm misunderstanding.

@Connorhd
Copy link
Author

Connorhd commented Jun 6, 2009

What if I don't want Content-Length and also don't want Transfer-Encoding set?

@ry
Copy link

ry commented Jun 6, 2009

illegal http 1.1 message. there needs to be a way to say how long the messages in order to support request pipelining.

HenryRawas pushed a commit to HenryRawas/node that referenced this issue Jun 22, 2011
bnoordhuis added a commit that referenced this issue Apr 10, 2013
Call SetPointerInInternalField(0, NULL) rather than
SetInternalField(0, Undefined()).

Fixes the following spurious NULL pointer dereference in debug builds:

  #0  0x03ad2821 in v8::internal::FixedArrayBase::length ()
  #1  0x03ad1dfc in v8::internal::FixedArray::get ()
  #2  0x03ae05dd in v8::internal::Context::global_object ()
  #3  0x03b6b87d in v8::internal::Context::builtins ()
  #4  0x03ae1871 in v8::internal::Isolate::js_builtins_object ()
  #5  0x03ab4fab in v8::CallV8HeapFunction ()
  #6  0x03ab4d4a in v8::Value::Equals ()
  #7  0x03b4f38b in CheckEqualsHelper ()
  #8  0x03ac0f4b in v8::Object::SetInternalField ()
  #9  0x06a99ddd in node::ObjectWrap::~ObjectWrap ()
  #10 0x06a8b051 in node::Buffer::~Buffer ()
  #11 0x06a8afbb in node::Buffer::~Buffer ()
  #12 0x06a8af5e in node::Buffer::~Buffer ()
  #13 0x06a9e569 in node::ObjectWrap::WeakCallback ()
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants