This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Fix crypto hmac to accept binary keys + add test cases from rfc 2202 and #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and 4231 Fixes #324 Instead of converting buffers to strings and back again to char array directly use the buffer data in hmac_init (same as in hmac_update).
|
Although the original reporter closed the bug, the bug is still not fixed. I just rebased my patch (no changes necessary). |
|
Can you sign the CLA? |
|
Done |
|
I modified format a little. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crypto hmac to accept binary keys + add test cases from rfc 2202 and 4231
Fixes #324
Instead of converting buffers to strings and back again to char array
directly use the buffer data in hmac_init (same as in hmac_update).