Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

[tls] share SSL context between server's connections #1073

Closed
wants to merge 1 commit into from
Closed

[tls] share SSL context between server's connections #1073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions lib/crypto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ try {
}


function Credentials(secureProtocol) {
function Credentials(secureProtocol, context) {
if (!(this instanceof Credentials)) {
return new Credentials(secureProtocol);
}
Expand All @@ -45,22 +45,28 @@ function Credentials(secureProtocol) {
throw new Error('node.js not compiled with openssl crypto support.');
}

this.context = new SecureContext();

if (secureProtocol) {
this.context.init(secureProtocol);
if (context) {
this.context = context;
this.reuseContext = true;
} else {
this.context.init();
}
this.context = new SecureContext();

if (secureProtocol) {
this.context.init(secureProtocol);
} else {
this.context.init();
}
}
}

exports.Credentials = Credentials;


exports.createCredentials = function(options) {
exports.createCredentials = function(options, context) {
if (!options) options = {};
var c = new Credentials(options.secureProtocol);
var c = new Credentials(options.secureProtocol, context);

if (context) return c;

if (options.key) c.context.setKey(options.key);

Expand Down
23 changes: 15 additions & 8 deletions lib/tls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,16 +713,23 @@ function Server(/* [options], listener */) {

var self = this;

// Handle option defaults:
this.setOptions(options);

var sharedCreds = crypto.createCredentials({
key: self.key,
cert: self.cert,
ca: self.ca,
ciphers: self.ciphers,
secureProtocol: self.secureProtocol,
crl: self.crl
});

sharedCreds.context.setCiphers('RC4-SHA:AES128-SHA:AES256-SHA');

// constructor call
net.Server.call(this, function(socket) {
var creds = crypto.createCredentials({
key: self.key,
cert: self.cert,
ca: self.ca,
secureProtocol: self.secureProtocol,
crl: self.crl
});
creds.context.setCiphers('RC4-SHA:AES128-SHA:AES256-SHA');
var creds = crypto.createCredentials(null, sharedCreds.context);

var pair = new SecurePair(creds,
true,
Expand Down