This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Update child_process.markdown, fix VIP example #25572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original logic would have sent the socket to both child processes instead of just one. By adding the else statement, it should now only send to one child process.
| @@ -308,9 +308,10 @@ socket to a "special" child process. Other sockets will go to a "normal" process | |||
| if (socket.remoteAddress === '74.125.127.100') { | |||
| special.send('socket', socket); | |||
| return; | |||
| } | |||
| } else { | |||
| // just the usual dudes | |||
There was a problem hiding this comment.
Can you remove this line. I'm amazed the word dudes is here actually.
|
The addition of the else is unnecessary. The return statement within the if takes care of the potential control flow issue. That said, @cjihrig is right about the "dudes" comment. That should go. |
|
Closing this here. I've opened an PR with a commit that removes the |
jasnell
added a commit
to jasnell/node
that referenced
this pull request
Aug 26, 2015
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Aug 26, 2015
per: nodejs/node-v0.x-archive#25572 (comment) Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: #2378
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Aug 26, 2015
per: nodejs/node-v0.x-archive#25572 (comment) Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: #2378
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original logic would have sent the socket to both child processes instead of just one. By adding the else statement, it should now only send to one child process.