Add support for building on ARM #25641
Conversation
This patch was sourced from a FreeBSD PR Source: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201227 Author: Mikael Urankar
| @@ -50,6 +50,35 @@ bool CpuFeatures::initialized_ = false; | |||
| unsigned CpuFeatures::supported_ = 0; | |||
| unsigned CpuFeatures::found_by_runtime_probing_ = 0; | |||
|
|
|||
| #ifdef __arm__ | |||
|
|
|||
| bool OS::ArmCpuHasFeature(CpuFeature feature) { | |||
There was a problem hiding this comment.
Why defining these functions in the ARM assembler for all OSes? Wouldn't that change break ARM support on platforms other than the one for which it was specifically written?
There was a problem hiding this comment.
I've screwed up this part of the patch... These changes should go in deps/v8/src/platform-freebsd.cc
|
@feld Thank you for your interest in running node v0.10 on ARMv6 and FreeBSD. I added a few comments, mostly so that I can understand some of the details in this patch. Let's see what this patch would look like at the end of the review process. At that time we'll be in a better place to evaluate whether it could land in this repository or should be kept as a patch in FreeBSD's ports. |
|
@mikaelu Thank you very much for the feedback! 👍 Any comment on #25641 (comment) and #25641 (comment)? |
|
good collaboration guys 👍 |
|
@misterdjules ... is this something we're going to land in v0.10? |
|
@nodejs/lts & @nodejs/build I'm inclined to say we shouldn't land this given that v4+ has proper ARM support and adding it back to v0.10 is just adding additional maintenance burden, thoughts? |
|
Agreed
|
|
I'd say this isn't appropriate for LTS or maintenance releases. |
|
done sorry @feld, hopefully you're sorted on v4.x now though |
This patch was sourced from a FreeBSD PR
Source: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201227
Author: Mikael Urankar