This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
doc: updates cherry picked from master #25811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current wording "This module is used for writing unit tests for your applications, you can access it with require('assert')." implies that this module should only be used in development while unit testing.
The article "Error Handling in Node.js" by Joyent (https://www.joyent.com/developers/node/design/errors) uses the assert module in an efficient way to validate required function arguments.
No offense to @izs, but the doxygen he put up 3.5 years ago isn't accurate for node 0.12 nor io.js. I'm trying to keep up and have multiple sets of doxygen of v8 available at http://v8dox.com/
jasnell
force-pushed
the
v0.12-doc-updates2
branch
from
c21c235
to
8cae25e
Compare
|
LGTM 👍 ! |
jasnell
pushed a commit
that referenced
this pull request
Aug 13, 2015
PR-URL: #25811 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Aug 13, 2015
The current wording "This module is used for writing unit tests for your applications, you can access it with require('assert')." implies that this module should only be used in development while unit testing.
The article "Error Handling in Node.js" by Joyent (https://www.joyent.com/developers/node/design/errors) uses the assert module in an efficient way to validate required function arguments.
PR-URL: #25811
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Aug 13, 2015
PR-URL: #25811 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Aug 13, 2015
No offense to @izs, but the doxygen he put up 3.5 years ago isn't accurate for node 0.12 nor io.js. I'm trying to keep up and have multiple sets of doxygen of v8 available at http://v8dox.com/ PR-URL: #25811 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Aug 13, 2015
|
Landed! |
|
@jasnell @srl295 Thank you for taking care of landing these changes. Some of the commits in this PR have commit message that do not follow our contribution guidelines. Please keep an eye open for these in the future, as having correctly formatted commit message helps when investigating problems, formatting changelogs, and generally when doing housekeeping around the code. |
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
The current wording "This module is used for writing unit tests for your applications, you can access it with require('assert')." implies that this module should only be used in development while unit testing.
The article "Error Handling in Node.js" by Joyent (https://www.joyent.com/developers/node/design/errors) uses the assert module in an efficient way to validate required function arguments.
PR-URL: nodejs#25811
Reviewed-By: James M Snell <jasnell@gmail.com>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
PR-URL: nodejs#25811 Reviewed-By: James M Snell <jasnell@gmail.com>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
No offense to @izs, but the doxygen he put up 3.5 years ago isn't accurate for node 0.12 nor io.js. I'm trying to keep up and have multiple sets of doxygen of v8 available at http://v8dox.com/ PR-URL: nodejs#25811 Reviewed-By: James M Snell <jasnell@gmail.com>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
PR-URL: nodejs#25811 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another round of documentation updates cherrypicked from master.
These were previously reviewed and signed off already.