Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

deps: upgrade to npm 2.13.4 #25825

Closed
wants to merge 1 commit into from
Closed

deps: upgrade to npm 2.13.4 #25825

wants to merge 1 commit into from

Conversation

zkat
Copy link

@zkat zkat commented Aug 8, 2015

These releases are included in this PR:

The latest version just includes a thing to make npm version work in git submodules. Previous releases are mostly just bugfixes, docs, etc.

r: @jasnell

( is this enough of a CC? This is what I understood from when we talked earlier today :) )

@jasnell
Copy link
Member

jasnell commented Aug 16, 2015

Yes, this is great! I'll work on getting this landed on Monday.

@jasnell
Copy link
Member

jasnell commented Aug 18, 2015

@misterdjules @orangemocha @mhdawson ... do any of you see a reason to hold off on this? If not, I'll try to get it landed today

@jasnell
Copy link
Member

jasnell commented Aug 18, 2015

@zkat ... just a thought... it would be good to start figuring out some kind of test suite for npm updates like this. Based on the conversation at the summit, the "contract" between node and npm is somewhat murky right now and a test suite within node may be the thing to help clear things up.

@trevnorris
Copy link

All changes are in deps/npm/ so not sure exactly what's supposed to be reviewed, but the update LGTM.

@misterdjules
Copy link

@jasnell Before landing npm upgrades in v0.12, we need to run the npm tests against the current tip of v0.12. I do that by building node, installing it so that it's in the path, and running make test-npm. You will also need to install couchdb, otherwise some (significant) tests are skipped.

I run these tests on OSX, and having all tests pass on OSX is enough for me to consider a npm upgrade good to merge.

@jasnell
Copy link
Member

jasnell commented Aug 19, 2015

Ok. Will work on that today. (@zkat sorry it keeps slipping)

jasnell pushed a commit that referenced this pull request Aug 21, 2015
PR-URL: #25825
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 21, 2015

Landed in f693565

@jasnell jasnell closed this Aug 21, 2015
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Nov 4, 2016
PR-URL: nodejs#25825
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants