Move this.pause to fix #5927 #5929
Conversation
Ditto for the 'removeListener' event.
Before this commit, fs.chown() and fs.fchown() coerced the uid and gid arguments to signed integers which is wrong because uid_t and gid_t are unsigned on most all platforms and IDs that don't fit in a signed integer do exist. This commit changes the aforementioned functions to take unsigned ints instead. No test because we can't assume the system has [GU]IDs that large. This change depends on joyent/libuv@d779eb5. Fixes #5890.
The return values from uv_cpu_info() don't necessarily fit in a 32 bits signed integer. Fixes #5732.
* uv: Upgrade to v0.10.13 * npm: Upgrade to v1.3.5 * os: Don't report negative times in cpu info (Ben Noordhuis) * fs: Handle large UID and GID (Ben Noordhuis) * url: Fix edge-case when protocol is non-lowercase (Shuan Wang) * doc: Streams API Doc Rewrite (isaacs) * node: call MakeDomainCallback in all domain cases (Trevor Norris) * crypto: fix memory leak in LoadPKCS12 (Fedor Indutny)
And process.getgid() too. Commit ed80638 changed fs.chown() and fs.fchown() to only accept unsigned integers. Make process.getuid() and process.getgid() follow suit. This commit should unbreak npm on OS X - it's hitting the new 'uid must be an unsigned int' check when installing as e.g. user 'nobody' (which has an UID of -2 in /etc/passwd or 4294967294 when cast to an uid_t.) Fixes #5904.
* src: fix process.getuid() return value (Ben Noordhuis)
The title shouldn't be too long; libuv's uv_set_process_title() out of security considerations no longer overwrites envp, only argv, so the maximum title length is possibly quite short. Fixes #5908.
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit danielchatfield/node@fdf07d3f85764e8cfa8474dc7f519aa6e485e897 has the following error(s):
The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
|
@danielchatfield why did you close the issue? if it was to please the bot, you don't need to open a new one to do so |
|
@tjfontaine github automatically closed it because I had to delete the branch (should have read contributing more closely first). When I push the new branch github might reopen it, we'll have to see. |
Pause should be called before _setRawMode to prevent things going wonky in windows (see #5927).
|
@tjfontaine I can't see any way to change the target branch so I'm going to have to open a new pull request. |
On windows 8 (and maybe other versions of windows) if
this.pause()isn't called before_setRawModethen things go a bit wonky (see #5927).