Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

New failing test: 'finish' firing before _flush is done in async case. #7612

Closed
wants to merge 2 commits into from
Closed

New failing test: 'finish' firing before _flush is done in async case. #7612

wants to merge 2 commits into from

Commits on May 13, 2014

  1. typo fix: s/assymetric/asymmetric/

    @markstos
    markstos committed May 13, 2014
    Configuration menu
    Copy the full SHA
    12e3ec4 View commit details
    Browse the repository at this point in the history

  2. New failing test: 'finish' firing before _flush is done in async case. 

    The 'finish' event is documented to fire with flushing is done:
When "all data has been flushed to the underlying system".

However, it appears be fired too early in the case of Transform streams
which make an async call. process.nextTick is used here but I ran into
this in a real-world case of making a call to a Mongo database.

This new failing test illustrates the apparent bug. When the code is
_flush is synchronous, there's no problem.

It fails with both 0.10.x and the latest from the 0.11 branch as well.
    @markstos
    markstos committed May 13, 2014
    Configuration menu
    Copy the full SHA
    5f014e7 View commit details
    Browse the repository at this point in the history