using higher versions...Feature/update v8

[indutny]

I'm up to considering using higher versions...

[indutny]

cc @trevnorris appears to be passing tests (Haven't tested pummel yet).

[Fishrock123]

So for reference from the previous PR thread:

The latest v8 3.29 lands a whole bunch of ES6 stuff that everyone wants.

And, the current working v8 is 3.30 as of yesterday:
v8/v8@0191cfb

[jonathanong]

v8 version with generators enabled by default, please 💃

[trevnorris]

@indutny Intense. I'll have to give this a thorough review. Guess if everything is actually working well then I'm not opposed to it.

[trevnorris]

@indutny First we should land #7719.

[trevnorris]

simple/test-debug-brk-no-arg.js is failing with:

AssertionError: false == true
    at ChildProcess.<anonymous> (/var/projects/node/test/simple/test-debug-brk-no-arg.js:33:3)

make test-addons now fails with:

/var/projects/node/src/node.h:181:44: error: unknown type name 'uv_loop_t'

[indutny]

Yep, test-addons is failing indeed. But I wonder how it could fail with brk-no-arg.js... It just works fine for me every time, and I spent **king 1 hour figuring out what was broken with it :).

[indutny]

Pushed a fix for test-addons, test works just fine for me...

[indutny]

@trevnorris I'm also up for moving to 3.29 before v0.12.

[trevnorris]

@indutny Can you explain the need for the fix for uv_loop_s and why it needs to be done that way?

Also, right now IRHydra2 is borked. I'm waiting for @mraleph to get back with me about why this is happening.

[indutny]

@trevnorris this is how we roll with C :) Basically, uv.h is not included from node.h so it doesn't know anything about uv_loop_t. Thus we need to forward-declare it.

[trevnorris]

Oops. Didn't notice that use of uv_loop_t was new.

@indutny I assume you're running OSX. Do you have a Linux box you can try to reproduce that failure with?

[refack]

@trevnorris confirming simple/test-debug-brk-no-arg.js breaks on Lubuntu 3.13.0-36-generic #63-Ubuntu SMP x86_64. @indutny with your blessing I'm digging into it.

[indutny]

@refack go ahead :)

[refack]

Also a report from Windows 8.1 x64 - https://gist.github.com/refack/774a677868de42757b57
(and some other failures related to #8385 - path casing).
I'm on it.

[indutny]

@refack this cluster things are happening because node.cc is no longer printing Debugger listening on port.... It happens on other thread now, and this is how it should actually be. (Just some insights for you).

[refack]

10x

[trevnorris]

We'll need to backport v8/v8@be6e43289 and v8/v8@6a8f74efc8c (just squash them together) so we don't loose IRHydra support.

[trevnorris]

@refack let me know if you need any help with simple/test-debug-brk-no-arg.js. Otherwise I'll be looking into some other issues.

[trevnorris]

Here's the exact diff to apply: https://gist.github.com/trevnorris/236f9f2cd88f2bac8a76

This only is needed in 3.28. It's been fixed in latest 3.29.

[indutny]

@trevnorris: applied.

[indutny]

@refack sorry, I took a peek look at the issue with tests. Looks like there is serious issue with a handle cleanup, I'd better do it myself since I want to land it ASAP.

[indutny]

Hahah, thanks man. Does it work better?

[refack]

Much better than what we had before on v0.12 (I did not have much "production" experience with my implementation, but I assume it would have been similar).