src/node.cc: fix OpenSSL build error #8761
Conversation
Signed-off-by: Jörg Krause <jkrause@posteo.de>
| @@ -2579,12 +2580,14 @@ static void ParseArgs(int argc, char **argv) { | |||
| p = 1 + strchr(arg, '='); | |||
| max_stack_size = atoi(p); | |||
| argv[i] = const_cast<char*>(""); | |||
| #if HAVE_OPENSSL | |||
There was a problem hiding this comment.
advice: the command option should be indifferent imo, perhaps should we clue someone to the "ssl2/3 not supported"?
|
@misterdjules @shigeki ... any thoughts on this one? |
|
My tests show this PR fixes the issue is fixed. Here was my process:
This process passed without any issue where as prior to this PR it would fail. Of course, the test suite is not aware that you compiled without SSL so there are a number of failing tests but based on visual examination, all were as expected: |
|
Ok, then closing this issue. Can reopen if it proves necessary. Thank you @whitlockjc for the test! |
|
No, this PR fixes the issue. Sorry that wasn't clear. |
|
Ha! Ok my apologies |
|
Hmm... It won't let me reopen... |
|
Ah... can't reopen because the original source repo for this was deleted... hmmm.... @whitlockjc, are you having issues with this on v0.10.40? or v0.12.7? |
|
I was able to reproduce with |
|
Yeah looks like we'll need it submitted again.
|
Since version 0.10.33 (commit d601c76) building nodejs without OpenSSL is broken. This issue is already reported upstream: #8676.
This issue is fixed by this patch.
Signed-off-by: Jörg Krause jkrause@posteo.de