This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
timers: throw on all invalid timer delays #8823
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit causes all timer functions to throw if the provided delay is anything other than a non-negative, finite number. No type coercion is performed, as it can lead to subtle bugs.
This is a rewrite of #8739 to target the 0.12 branch. The original PR was opened to address #8618. On #8739 and IRC, it was decided that the timer API would be made as strict as possible to avoid subtle bugs. This required updating a number of existing tests that did not pass a second argument to
setTimeout()
andsetInterval()
.R= @misterdjules or @tjfontaine