This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'.' and '..' are directory specs and resolving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fix nodejs#8992
LGTM. I'll land it after the 0.10 to 0.12 merge. |
That also affects v0.10:
Thus, I suggest landing this in v0.10 first. Removing from the 0.11.15 milestone as a consequence. I'm not sure when we want to land it in v0.10, so I'm not adding it to any v0.10 milestone for now, but feel free to do so. |
@misterdjules Sounds like a good idea. Might as well land this on the v0.10 branch now. Can't think of a reason to hold it back. Though, does it apply cleanly? |
@trevnorris It applies cleanly to v0.10. |
@misterdjules Feel free to throw it on. |
When this is going to be merged? |
Thanks. Landed in ad06848. |
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Mar 17, 2015
'.' and '..' are directory specs and resolving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fixes: nodejs#8992 PR-URL: nodejs#9010 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.
and..
are directory specs and resolving urls -with or without the hostname- with.
and..
should add a trailing slash to the end of the url. (#8992)The array
srcPath
contains url segments. If the path doesn't contain a hostname, the first element will be an empty string. In that case, if the last element is.
or..
, the final value must end with a trailing slash.