This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
doc: i18n: add license content from ICU #9038
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe the build process could add some |
Adding to the 0.11.15 milestone as installers will start shipping with ICU enabled from that release. |
Thank you! Two comments:
Other than that, LGTM! |
Node should present ICU's license. Added license info from: http://source.icu-project.org/repos/icu/icu/trunk/license.html All text pasted. Long lines wrapped. (original is HTML.) doc: i18n: include ICU license
srl295
force-pushed
the
srl-v0.12-license
branch
from
January 16, 2015 16:16
0aab45e
to
7ac6212
Compare
@misterdjules fixed. I left the URL in place but can remove that also. |
Longterm for improving the installers in general it would be nice if we broke out each license, but this LGTM |
@misterdjules can you add the i18n tag here also please? thanks |
srl295
added a commit
to srl295/node
that referenced
this pull request
Aug 13, 2015
* turn on small-icu by default for builds (Makefile+Windows) * add license info from ICU http://source.icu-project.org/repos/icu/icu/trunk/license.html All text pasted. Long lines wrapped. (original is HTML.) Port from joyent/node of: * nodejs#26 * port of joyent/node 67f87a7 * nodejs/node-v0.x-archive#9038 * Merge from joyent/node 70d04e7 * Merge from joyent/node 6168fe6 * merge from joyent/node e670732 PR-URL: nodejs#2264
srl295
added a commit
to nodejs/node
that referenced
this pull request
Aug 13, 2015
* turn on small-icu by default for builds (Makefile+Windows) * add license info from ICU http://source.icu-project.org/repos/icu/icu/trunk/license.html All text pasted. Long lines wrapped. (original is HTML.) Port from joyent/node of: * #26 * port of joyent/node 67f87a7 * nodejs/node-v0.x-archive#9038 * Merge from joyent/node 70d04e7 * Merge from joyent/node 6168fe6 * merge from joyent/node e670732 PR-URL: #2264 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Fixes: #238
srl295
added a commit
to nodejs/node
that referenced
this pull request
Aug 17, 2015
* turn on small-icu by default for builds (Makefile+Windows) * add license info from ICU http://source.icu-project.org/repos/icu/icu/trunk/license.html All text pasted. Long lines wrapped. (original is HTML.) Port from joyent/node of: * #26 * port of joyent/node 67f87a7 * nodejs/node-v0.x-archive#9038 * Merge from joyent/node 70d04e7 * Merge from joyent/node 6168fe6 * merge from joyent/node e670732 PR-URL: #2264 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Fixes: #238
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node, when built with ICU, should present ICU's license.
Added license info from:
http://source.icu-project.org/repos/icu/icu/trunk/license.html
All text pasted. Long lines wrapped. (original is HTML.)
Note wording that ICU's license may or may not apply, if node isn't
built with it.