Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

doc: i18n: add license content from ICU #9038

Closed
wants to merge 1 commit into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Jan 16, 2015

Node, when built with ICU, should present ICU's license.

Added license info from:
http://source.icu-project.org/repos/icu/icu/trunk/license.html
All text pasted. Long lines wrapped. (original is HTML.)

Note wording that ICU's license may or may not apply, if node isn't
built with it.

@srl295
Copy link
Member Author

srl295 commented Jan 16, 2015

Maybe the build process could add some tools/icu/ICU-LICENSE to the LICENSE file. (Or at that point, it could reformat deps/icu/license.html and be super up to date)

@misterdjules misterdjules added this to the 0.11.15 milestone Jan 16, 2015
@misterdjules
Copy link

Adding to the 0.11.15 milestone as installers will start shipping with ICU enabled from that release.

@misterdjules
Copy link

Thank you! Two comments:

  • The wording about the fact that the ICU license may or may not apply should be removed (as well as the corresponding explanation in the commit message). The LICENSE file is included and displayed as is in the package installers, and in that case it applies all the time.
  • The newline at the end of the file was removed, could you please put it back?

Other than that, LGTM!

Node should present ICU's license.

Added license info from:
 http://source.icu-project.org/repos/icu/icu/trunk/license.html
All text pasted. Long lines wrapped. (original is HTML.)

doc: i18n: include ICU license
@srl295
Copy link
Member Author

srl295 commented Jan 16, 2015

@misterdjules fixed. I left the URL in place but can remove that also.

@tjfontaine
Copy link

Longterm for improving the installers in general it would be nice if we broke out each license, but this LGTM

@misterdjules
Copy link

@srl295 Thanks! Landed in 70d04e7.

@srl295
Copy link
Member Author

srl295 commented Jan 16, 2015

@misterdjules can you add the i18n tag here also please? thanks

@srl295 srl295 deleted the srl-v0.12-license branch January 16, 2015 19:35
srl295 added a commit to srl295/node that referenced this pull request Aug 13, 2015
* turn on small-icu by default for builds (Makefile+Windows)
* add license info from ICU
  http://source.icu-project.org/repos/icu/icu/trunk/license.html
  All text pasted. Long lines wrapped. (original is HTML.)

Port from joyent/node of:
* nodejs#26
 * port of joyent/node 67f87a7
* nodejs/node-v0.x-archive#9038
 * Merge from joyent/node 70d04e7
 * Merge from joyent/node 6168fe6
 * merge from joyent/node e670732

PR-URL: nodejs#2264
srl295 added a commit to nodejs/node that referenced this pull request Aug 13, 2015
* turn on small-icu by default for builds (Makefile+Windows)
* add license info from ICU
  http://source.icu-project.org/repos/icu/icu/trunk/license.html
  All text pasted. Long lines wrapped. (original is HTML.)

Port from joyent/node of:
* #26
 * port of joyent/node 67f87a7
* nodejs/node-v0.x-archive#9038
 * Merge from joyent/node 70d04e7
 * Merge from joyent/node 6168fe6
 * merge from joyent/node e670732

PR-URL: #2264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Fixes: #238
srl295 added a commit to nodejs/node that referenced this pull request Aug 17, 2015
* turn on small-icu by default for builds (Makefile+Windows)
* add license info from ICU
  http://source.icu-project.org/repos/icu/icu/trunk/license.html
  All text pasted. Long lines wrapped. (original is HTML.)

Port from joyent/node of:
* #26
 * port of joyent/node 67f87a7
* nodejs/node-v0.x-archive#9038
 * Merge from joyent/node 70d04e7
 * Merge from joyent/node 6168fe6
 * merge from joyent/node e670732

PR-URL: #2264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Fixes: #238
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants