Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: __config: No such file or directory #26

Closed
schuay opened this issue Nov 22, 2017 · 5 comments
Closed

Build failure: __config: No such file or directory #26

schuay opened this issue Nov 22, 2017 · 5 comments

Comments

@schuay
Copy link

schuay commented Nov 22, 2017

On current canary branch head (30cba1b), linux:

./configure && make -j32
[...]
  g++ '-DNODE_ARCH="x64"' '-DNODE_PLATFORM="linux"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '-D__POSIX__' '-DHAVE_OPENSSL=1' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DNODE_HAVE_SMALL_ICU=1' '-DNGHTTP2_STATICLIB' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DHTTP_PARSER_STRICT=0' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-D_POSIX_C_SOURCE=200112' -I../src -I../tools/msvs/genfiles -I/my_local_path_snipped/node-v8/out/Release/obj/gen -I/my_local_path_snipped/node-v8/out/Release/obj/gen/include -I../deps/nghttp2/lib/includes -I../deps/openssl/openssl/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -I../deps/zlib -I../deps/http_parser -I../deps/cares/include -I../deps/uv/include  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /my_local_path_snipped/node-v8/out/Release/.deps//my_local_path_snipped/node-v8/out/Release/obj.target/node/gen/node-debug-support.o.d.raw   -c -o /my_local_path_snipped/node-v8/out/Release/obj.target/node/gen/node-debug-support.o /my_local_path_snipped/node-v8/out/Release/obj/gen/node-debug-support.cc
/my_local_path_snipped/node-v8/out/Release/obj/gen/node-debug-support.cc:8:20: fatal error: __config: No such file or directory
 #include <__config>

The path exists, but is not picked up by the build:

$ find . -name __config
./deps/v8/buildtools/third_party/libc++/trunk/include/experimental/__config
./deps/v8/buildtools/third_party/libc++/trunk/include/__config
@bnoordhuis
Copy link
Member

Introduced in nodejs/node#14901, which, mea culpa, could probably have used another round of review.

cc @mmarchini

@mmarchini
Copy link

I'll take a look at this, but I'm having trouble reproducing it on Ubuntu 16.04. Maybe I'm doing something wrong? Build is working and my ./deps/v8/ doesn't have a buildtools directory:

[10:15:21] node-v8 / (canary)
 > ls deps/v8/
AUTHORS     BUILD.gn         CODE_OF_CONDUCT.md   docs      include  LICENSE.fdlibm      LICENSE.valgrind  OWNERS        samples                 test         tools
base        build_overrides  codereview.settings  gni       infra    LICENSE.strongtalk  Makefile          PRESUBMIT.py  snapshot_toolchain.gni  testing      WATCHLISTS
benchmarks  ChangeLog        DEPS                 gypfiles  LICENSE  LICENSE.v8          Makefile.android  README.md     src                     third_party

@schuay
Copy link
Author

schuay commented Nov 22, 2017

Interesting, I can't repro either when building from a clean checkout.

make clean didn't help.
git clean -xfd did.

Apparently there were some untracked files/directory in deps/v8 that messed up the build. Closing, thanks for investigating.

@refack
Copy link

refack commented Nov 23, 2017

So it seems the issue still reproduces when building make test-v8: https://ci.nodejs.org/job/node-test-commit-v8-linux/1069/

targos added a commit to targos/node that referenced this issue Nov 23, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in [1] to use ignored
files while generating `node-debug-support.cc`.

[1]: nodejs#14901

Fixes: nodejs/node-v8#26
@schuay
Copy link
Author

schuay commented Nov 23, 2017

Right, make test-v8 fails for me with

.././src/inspector/string-util.h:8:10: fatal error: 'memory' file not found
#include <memory>

@schuay schuay reopened this Nov 23, 2017
MylesBorins pushed a commit to nodejs/node that referenced this issue Dec 12, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in [1] to use ignored
files while generating `node-debug-support.cc`.

[1]: #14901

PR-URL: #17269
Fixes: nodejs/node-v8#26
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Dec 12, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in [1] to use ignored
files while generating `node-debug-support.cc`.

[1]: #14901

PR-URL: #17269
Fixes: nodejs/node-v8#26
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
gibfahn pushed a commit to nodejs/node that referenced this issue Dec 19, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in [1] to use ignored
files while generating `node-debug-support.cc`.

[1]: #14901

PR-URL: #17269
Fixes: nodejs/node-v8#26
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
gibfahn pushed a commit to nodejs/node that referenced this issue Dec 19, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in [1] to use ignored
files while generating `node-debug-support.cc`.

[1]: #14901

PR-URL: #17269
Fixes: nodejs/node-v8#26
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
gibfahn pushed a commit to nodejs/node that referenced this issue Dec 20, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in [1] to use ignored
files while generating `node-debug-support.cc`.

[1]: #14901

PR-URL: #17269
Fixes: nodejs/node-v8#26
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants