Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile canary #36

Closed
joyeecheung opened this issue Jan 26, 2018 · 2 comments
Closed

Cannot compile canary #36

joyeecheung opened this issue Jan 26, 2018 · 2 comments

Comments

@joyeecheung
Copy link
Member

v8/v8@f9934aa have broken the canary branch. This patch fixes that.

diff --git a/node.gypi b/node.gypi
index 386601906f..bc9db9b814 100644
--- a/node.gypi
+++ b/node.gypi
@@ -38,12 +38,12 @@
       ],
     }],
     [ 'node_enable_d8=="true"', {
-      'dependencies': [ 'deps/v8/src/d8.gyp:d8' ],
+      'dependencies': [ 'deps/v8/gypfiles/d8.gyp:d8' ],
     }],
     [ 'node_use_bundled_v8=="true"', {
       'dependencies': [
-        'deps/v8/src/v8.gyp:v8',
-        'deps/v8/src/v8.gyp:v8_libplatform'
+        'deps/v8/gypfiles/v8.gyp:v8',
+        'deps/v8/gypfiles/v8.gyp:v8_libplatform'
       ],
     }],
     [ 'node_use_v8_platform=="true"', {
@@ -93,7 +93,7 @@
       'defines': [ 'NODE_NO_BROWSER_GLOBALS' ],
     } ],
     [ 'node_use_bundled_v8=="true" and v8_postmortem_support=="true"', {
-      'dependencies': [ 'deps/v8/src/v8.gyp:postmortem-metadata' ],
+      'dependencies': [ 'deps/v8/gypfiles/v8.gyp:postmortem-metadata' ],
       'conditions': [
         # -force_load is not applicable for the static library
         [ 'force_load=="true"', {

was there an issue about this?

@mmarchini
Copy link

Maybe it's related to nodejs/node#18262 (comment)? /cc @hashseed

@hashseed
Copy link
Member

Yes indeed. This is in preparation to remove gypfiles altogether. It was discussed that the gypfiles that Node.js will inherit should be collected to the same location.

targos pushed a commit to nodejs/node that referenced this issue Jan 26, 2018
targos pushed a commit to nodejs/node that referenced this issue Feb 3, 2018
targos pushed a commit to nodejs/node that referenced this issue Feb 12, 2018
targos pushed a commit to nodejs/node that referenced this issue Mar 28, 2018
MylesBorins pushed a commit to targos/node that referenced this issue Apr 2, 2018
targos pushed a commit to nodejs/node that referenced this issue Apr 3, 2018
targos pushed a commit to nodejs/node that referenced this issue Apr 5, 2018
targos pushed a commit to nodejs/node that referenced this issue Apr 7, 2018
targos pushed a commit to nodejs/node that referenced this issue Apr 10, 2018
MylesBorins pushed a commit to targos/node that referenced this issue Apr 11, 2018
MylesBorins pushed a commit to nodejs/node that referenced this issue Apr 11, 2018
Refs: v8/v8@f9934aa
Fixes: nodejs/node-v8#36

PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit to nodejs/node that referenced this issue Apr 16, 2018
Refs: v8/v8@f9934aa
Fixes: nodejs/node-v8#36

PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants