fix: url parser should throw error on invalid ipv4

nodejs · Apr 29, 2022 · 0af57b1 · 0af57b1
1 parent 27ecf1d
commit 0af57b1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -430,6 +430,7 @@ void URLHost::ParseIPv4Host(const char* input, size_t length, bool* is_ipv4) {
     pointer++;
   }
   CHECK_GT(parts, 0);
+  CHECK_LE(parts, 4);
   *is_ipv4 = true;
 
   // If any but the last item in numbers is greater than 255, return failure.

diff --git a/test/parallel/test-whatwg-url-constructor.js b/test/parallel/test-whatwg-url-constructor.js
@@ -142,3 +142,11 @@ function runURLSearchParamTests() {
 runURLSearchParamTests()
 runURLConstructorTests()
 /* eslint-enable */
+
+const message = {
+  code: 'ERR_INVALID_URL',
+  name: 'TypeError',
+  message: 'Invalid URL',
+};
+
+assert_throws(() => new URL('https://256.256.256.256.256'), message);