Skip to content

Commit

Permalink
test: use fixtures in test-https-set-timeout-server
Browse files Browse the repository at this point in the history
Task to replace the common.fixturesDir with the usage
of the common.fixtures module. At Node.js Interactive.
First PR to Node.js. Yay!

PR-URL: #15886
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Bob Clewell authored and jasnell committed Oct 13, 2017
1 parent c4231aa commit 0e1455b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/parallel/test-https-set-timeout-server.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,16 @@ if (!common.hasCrypto)
common.skip('missing crypto');

const assert = require('assert');
const fs = require('fs');
const fixtures = require('../common/fixtures');
const https = require('https');
const http = require('http');
const tls = require('tls');

const tests = [];

const serverOptions = {
key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`),
cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`)
key: fixtures.readKey('agent1-key.pem'),
cert: fixtures.readKey('agent1-cert.pem')
};

function test(fn) {
Expand Down

2 comments on commit 0e1455b

@Trott
Copy link
Member

@Trott Trott commented on 0e1455b Oct 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell Totally not a big deal (especially in light of landing a ton of commits at once), but that won't stop me from mentioning it: The first line is longer than 50 chars. #CoreValidateCommit

@bobclewell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott thanks for the feedback. I'll make sure all my future commit messages adhere to this rule.

Please sign in to comment.