Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: use fixtures in test-https-set-timeout-server
Task to replace the common.fixturesDir with the usage of the common.fixtures module. At Node.js Interactive. First PR to Node.js. Yay! PR-URL: #15886 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- Loading branch information
0e1455b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasnell Totally not a big deal (especially in light of landing a ton of commits at once), but that won't stop me from mentioning it: The first line is longer than 50 chars. #CoreValidateCommit
0e1455b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Trott thanks for the feedback. I'll make sure all my future commit messages adhere to this rule.