stream: improve inspector ergonomics

PR-URL: #53800 Fixes: #53789 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
nodejs · Aug 19, 2024 · 117f95b · 117f95b
1 parent ddfd540
commit 117f95b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js
@@ -2034,8 +2034,8 @@ function readableStreamError(stream, error) {
   assert(stream[kState].state === 'readable');
   stream[kState].state = 'errored';
   stream[kState].storedError = error;
-  stream[kIsClosedPromise].reject(error);
   setPromiseHandled(stream[kIsClosedPromise].promise);
+  stream[kIsClosedPromise].reject(error);
 
   const {
     reader,
@@ -2044,8 +2044,8 @@ function readableStreamError(stream, error) {
   if (reader === undefined)
     return;
 
-  reader[kState].close.reject(error);
   setPromiseHandled(reader[kState].close.promise);
+  reader[kState].close.reject(error);
 
   if (readableStreamHasDefaultReader(stream)) {
     for (let n = 0; n < reader[kState].readRequests.length; n++)

diff --git a/lib/internal/webstreams/writablestream.js b/lib/internal/webstreams/writablestream.js
@@ -761,15 +761,15 @@ function writableStreamRejectCloseAndClosedPromiseIfNeeded(stream) {
     };
   }
 
-  stream[kIsClosedPromise].reject(stream[kState]?.storedError);
   setPromiseHandled(stream[kIsClosedPromise].promise);
+  stream[kIsClosedPromise].reject(stream[kState]?.storedError);
 
   const {
     writer,
   } = stream[kState];
   if (writer !== undefined) {
-    writer[kState].close.reject?.(stream[kState].storedError);
     setPromiseHandled(writer[kState].close.promise);
+    writer[kState].close.reject?.(stream[kState].storedError);
   }
 }