Skip to content

Commit

Permalink
test: remove 512 bits test in test-tls-dhe.js
Browse files Browse the repository at this point in the history
Test of 512 bits key is failed after upgrading openssl-1.0.1o due to
its limit of 768 bits key size. Remove it and start from 1024 bits
test.

Reviewed-By: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs/node-v0.x-archive#25533
  • Loading branch information
Shigeki Ohtsu authored and mhdawson committed Jun 17, 2015
1 parent 097607c commit 139dbe8
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 14 deletions.
5 changes: 1 addition & 4 deletions test/fixtures/keys/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
all: agent1-cert.pem agent2-cert.pem agent3-cert.pem agent4-cert.pem agent5-cert.pem ca2-crl.pem ec-cert.pem dh512.pem dh1024.pem dh2048.pem
all: agent1-cert.pem agent2-cert.pem agent3-cert.pem agent4-cert.pem agent5-cert.pem ca2-crl.pem ec-cert.pem dh1024.pem dh2048.pem


#
Expand Down Expand Up @@ -170,9 +170,6 @@ ec-cert.pem: ec-csr.pem ec-key.pem
-signkey ec-key.pem \
-out ec-cert.pem

dh512.pem:
openssl dhparam -out dh512.pem 512

dh1024.pem:
openssl dhparam -out dh1024.pem 1024

Expand Down
4 changes: 0 additions & 4 deletions test/fixtures/keys/dh512.pem

This file was deleted.

7 changes: 1 addition & 6 deletions test/simple/test-tls-dhe.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,6 @@ function test(keylen, expectedCipher, cb) {
});
}

function test512() {
test(512, 'DHE-RSA-AES128-SHA256', test1024);
ntests++;
}

function test1024() {
test(1024, 'DHE-RSA-AES128-SHA256', test2048);
ntests++;
Expand All @@ -100,7 +95,7 @@ function testError() {
ntests++;
}

test512();
test1024();

process.on('exit', function() {
assert.equal(ntests, nsuccess);
Expand Down

0 comments on commit 139dbe8

Please sign in to comment.