net: return this from getConnections()

PR-URL: #13553 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Jan 17, 2018 · 19955c6 · 19955c6
1 parent 4afecfc
commit 19955c6
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/doc/api/net.md b/doc/api/net.md
@@ -121,6 +121,8 @@ connections use asynchronous `server.getConnections` instead.
 added: v0.9.7
 -->
 
+* Returns {net.Server}
+
 Asynchronously get the number of concurrent connections on the server. Works
 when sockets were sent to forks.
 

diff --git a/lib/net.js b/lib/net.js
@@ -1487,7 +1487,8 @@ Server.prototype.getConnections = function(cb) {
   }
 
   if (!this._usingSlaves) {
-    return end(null, this._connections);
+    end(null, this._connections);
+    return this;
   }
 
   // Poll slaves
@@ -1507,6 +1508,8 @@ Server.prototype.getConnections = function(cb) {
   this._slaves.forEach(function(slave) {
     slave.getConnections(oncount);
   });
+
+  return this;
 };
 
 

diff --git a/test/parallel/test-net-pingpong.js b/test/parallel/test-net-pingpong.js
@@ -16,10 +16,13 @@ function pingPongTest(port, host) {
 
   function onSocket(socket) {
     assert.strictEqual(socket.server, server);
-    server.getConnections(common.mustCall(function(err, connections) {
-      assert.ifError(err);
-      assert.strictEqual(connections, 1);
-    }));
+    assert.strictEqual(
+      server,
+      server.getConnections(common.mustCall(function(err, connections) {
+        assert.ifError(err);
+        assert.strictEqual(connections, 1);
+      }))
+    );
 
     socket.setNoDelay();
     socket.timeout = 0;