fixup: throw on negative length

nodejs · Aug 26, 2024 · 1dea557 · 1dea557
1 parent 9b0a26a
commit 1dea557
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lib/internal/buffer.js b/lib/internal/buffer.js
@@ -1040,6 +1040,9 @@ function addBufferPrototypeMethods(proto) {
     if (offset < 0 || offset > this.byteLength) {
       throw new ERR_BUFFER_OUT_OF_BOUNDS('offset');
     }
+    if (length < 0) {
+      throw new ERR_BUFFER_OUT_OF_BOUNDS('length');
+    }
     return asciiWriteStatic(this, string, offset, length);
   };
   proto.base64Write = base64Write;
@@ -1048,6 +1051,9 @@ function addBufferPrototypeMethods(proto) {
     if (offset < 0 || offset > this.byteLength) {
       throw new ERR_BUFFER_OUT_OF_BOUNDS('offset');
     }
+    if (length < 0) {
+      throw new ERR_BUFFER_OUT_OF_BOUNDS('length');
+    }
     return latin1WriteStatic(this, string, offset, length);
   };
   proto.hexWrite = hexWrite;
@@ -1056,6 +1062,9 @@ function addBufferPrototypeMethods(proto) {
     if (offset < 0 || offset > this.byteLength) {
       throw new ERR_BUFFER_OUT_OF_BOUNDS('offset');
     }
+    if (length < 0) {
+      throw new ERR_BUFFER_OUT_OF_BOUNDS('length');
+    }
     return utf8WriteStatic(this, string, offset, length);
   };
 }

diff --git a/test/parallel/test-buffer-write.js b/test/parallel/test-buffer-write.js
@@ -112,3 +112,11 @@ assert.strictEqual(Buffer.alloc(4)
   assert.strictEqual(buf.write('ww'), 1);
   assert.strictEqual(buf.toString(), 'w');
 }
+
+assert.throws(() =>
+{
+  const buf = Buffer.alloc(1);
+  assert.strictEqual(buf.asciiWrite('ww', 0, -1));
+  assert.strictEqual(buf.latin1Write('ww', 0, -1));
+  assert.strictEqual(buf.utf8Write('ww', 0, -1));
+});