test: implemented testNamePattens param in run

doc/api/errors.md

@@ -697,6 +697,14 @@ message thrown by `block` because that usage suggests that the user believes
 `message` is the expected message rather than the message the `AssertionError`
 will display if `block` does not throw.
 
+<a id="ERR_ARG_NOT_ALLOWED"></a>
+
+### `ERR_ARG_NOT_ALLOWED`
+
+A function argument that can't be accept depending of some logic restriction.
+e.g. The function `run(...)` from module `node:test` can't accept `testNamePatterns`
+param from programatic function and from CLI at same time. <a id="ERR_ARG_NOT_ITERABLE"></a>
+
 <a id="ERR_ARG_NOT_ITERABLE"></a>
 
 ### `ERR_ARG_NOT_ITERABLE`

file

@@ -0,0 +1 @@
+some content

lib/internal/errors.js

@@ -960,6 +960,7 @@ module.exports = {
 // Note: Node.js specific errors must begin with the prefix ERR_
 
 E('ERR_AMBIGUOUS_ARGUMENT', 'The "%s" argument is ambiguous. %s', TypeError);
+E('ERR_ARG_NOT_ALLOWED', '%s is already being assigned', TypeError);
 E('ERR_ARG_NOT_ITERABLE', '%s must be iterable', TypeError);
 E('ERR_ASSERTION', '%s', Error);
 E('ERR_ASYNC_CALLBACK', '%s must be a function', TypeError);

lib/internal/test_runner/runner.js

@@ -254,8 +254,9 @@ class FileTest extends Test {
 const runningProcesses = new SafeMap();
 const runningSubtests = new SafeMap();
 
-function runTestFile(path, root, inspectPort, filesWatcher) {
-  const subtest = root.createSubtest(FileTest, path, async (t) => {
+function runTestFile(options) {
+  const { path, root, inspectPort, filesWatcher, testNamePatterns } = options;
+  const subtest = root.createSubtest(FileTest, path, { testNamePatterns }, async (t) => {
     const args = getRunArgs({ path, inspectPort });
     const stdio = ['pipe', 'pipe', 'pipe'];
     const env = { ...process.env };
@@ -328,7 +329,7 @@ function runTestFile(path, root, inspectPort, filesWatcher) {
   return subtest.start();
 }
 
-function watchFiles(testFiles, root, inspectPort) {
+function watchFiles(testFiles, root, inspectPort, testNamePatterns) {
   const filesWatcher = new FilesWatcher({ throttle: 500, mode: 'filter' });
   filesWatcher.on('changed', ({ owners }) => {
     filesWatcher.unfilterFilesOwnedBy(owners);
@@ -342,7 +343,7 @@ function watchFiles(testFiles, root, inspectPort) {
         await once(runningProcess, 'exit');
       }
       await runningSubtests.get(file);
-      runningSubtests.set(file, runTestFile(file, root, inspectPort, filesWatcher));
+      runningSubtests.set(file, runTestFile({ file, root, inspectPort, filesWatcher, testNamePatterns }));
     }, undefined, (error) => {
       triggerUncaughtException(error, true /* fromPromise */);
     }));
@@ -354,7 +355,7 @@ function run(options) {
   if (options === null || typeof options !== 'object') {
     options = kEmptyObject;
   }
-  const { concurrency, timeout, signal, files, inspectPort, watch, setup } = options;
+  const { concurrency, timeout, signal, files, inspectPort, watch, setup, testNamePatterns } = options;
 
   if (files != null) {
     validateArray(files, 'options.files');
@@ -372,11 +373,11 @@ function run(options) {
   let postRun = () => root.postRun();
   let filesWatcher;
   if (watch) {
-    filesWatcher = watchFiles(testFiles, root, inspectPort);
+    filesWatcher = watchFiles(testFiles, root, inspectPort, testNamePatterns);
     postRun = undefined;
   }
   const runFiles = () => SafePromiseAllSettledReturnVoid(testFiles, (path) => {
-    const subtest = runTestFile(path, root, inspectPort, filesWatcher);
+    const subtest = runTestFile({ path, root, inspectPort, filesWatcher, testNamePatterns });
     runningSubtests.set(path, subtest);
     return subtest;
   });

lib/internal/test_runner/test.js

@@ -26,6 +26,7 @@ const { AbortController } = require('internal/abort_controller');
 const {
   codes: {
     ERR_INVALID_ARG_TYPE,
+    ERR_ARG_NOT_ALLOWED,
     ERR_TEST_FAILURE,
   },
   AbortError,
@@ -163,9 +164,16 @@ class Test extends AsyncResource {
   constructor(options) {
     super('Test');
 
-    let { fn, name, parent, skip } = options;
+    let { fn, name, parent, skip, testNamePatterns: _testNamePatterns } = options;
     const { concurrency, only, timeout, todo, signal } = options;
 
+    if (_testNamePatterns && testNamePatterns) {
+      throw new ERR_ARG_NOT_ALLOWED('testNamePatterns');
+    }
+    if (!_testNamePatterns) {
+      _testNamePatterns = testNamePatterns;
+    }
+
     if (typeof fn !== 'function') {
       fn = noop;
     }
@@ -224,10 +232,10 @@ class Test extends AsyncResource {
       this.timeout = timeout;
     }
 
-    if (testNamePatterns !== null) {
+    if (_testNamePatterns !== null) {
       // eslint-disable-next-line no-use-before-define
       const match = this instanceof TestHook || ArrayPrototypeSome(
-        testNamePatterns,
+        _testNamePatterns,
         (re) => RegExpPrototypeExec(re, name) !== null,
       );
 

test/fixtures/test-runner/test/random.cjs

@@ -2,3 +2,5 @@
 const test = require('node:test');
 
 test('this should pass');
+
+test('this should pass too');

test/parallel/test-runner-run.mjs

@@ -27,6 +27,14 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
   it('should succeed with a file', async () => {
     const stream = run({ files: [join(testFixtures, 'test/random.cjs')] });
     stream.on('test:fail', common.mustNotCall());
+    stream.on('test:pass', common.mustCall(2));
+    // eslint-disable-next-line no-unused-vars
+    for await (const _ of stream);
+  });
+
+  it('should succeed with a file and filter', async () => {
+    const stream = run({ files: [join(testFixtures, 'test/random.cjs')], testNamePatterns: [/too/] });
+    stream.on('test:fail', common.mustNotCall());
     stream.on('test:pass', common.mustCall(1));
     // eslint-disable-next-line no-unused-vars
     for await (const _ of stream);
@@ -35,7 +43,7 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
   it('should run same file twice', async () => {
     const stream = run({ files: [join(testFixtures, 'test/random.cjs'), join(testFixtures, 'test/random.cjs')] });
     stream.on('test:fail', common.mustNotCall());
-    stream.on('test:pass', common.mustCall(2));
+    stream.on('test:pass', common.mustCall(4));
     // eslint-disable-next-line no-unused-vars
     for await (const _ of stream);
   });