Skip to content

Commit

Permalink
build: split up cpplint to avoid long cmd lines
Browse files Browse the repository at this point in the history
Refactors cpplint slightly to allow multiple runs of it. This allows
downstream projects to run cpplint on their dependencies.

PR-URL: #14116
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: João Reis <reis@janeasystems.com>
  • Loading branch information
kfarnung authored and Fishrock123 committed Jul 19, 2017
1 parent 9675734 commit 23a66b2
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions vcbuild.bat
Original file line number Diff line number Diff line change
Expand Up @@ -435,12 +435,16 @@ goto cpplint

:cpplint
if not defined cpplint goto jslint
echo running cpplint
call :run-cpplint src\*.c src\*.cc src\*.h test\addons\*.cc test\addons\*.h test\cctest\*.cc test\cctest\*.h test\gc\binding.cc tools\icu\*.cc tools\icu\*.h
call :run-python tools/check-imports.py
goto jslint

:run-cpplint
if "%*"=="" goto exit
echo running cpplint '%*'
set cppfilelist=
setlocal enabledelayedexpansion
for /f "tokens=*" %%G in ('dir /b /s /a src\*.c src\*.cc src\*.h ^
test\addons\*.cc test\addons\*.h test\cctest\*.cc test\cctest\*.h ^
test\gc\binding.cc tools\icu\*.cc tools\icu\*.h') do (
for /f "tokens=*" %%G in ('dir /b /s /a %*') do (
set relpath=%%G
set relpath=!relpath:*%~dp0=!
call :add-to-list !relpath!
Expand All @@ -449,8 +453,7 @@ test\gc\binding.cc tools\icu\*.cc tools\icu\*.h') do (
set cppfilelist=%localcppfilelist%
)
call :run-python tools/cpplint.py %cppfilelist%
call :run-python tools/check-imports.py
goto jslint
goto exit

:add-to-list
echo %1 | findstr /c:"src\node_root_certs.h"
Expand Down

0 comments on commit 23a66b2

Please sign in to comment.