Skip to content

Commit

Permalink
test: check that benchmark tests are minimal
Browse files Browse the repository at this point in the history
Check that benchmark tests are not running longer than necessary by
confirming that they only produce one set of configs to report on per
benchmark file.

PR-URL: #21046
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
Trott authored and targos committed Jun 20, 2018
1 parent 9030e93 commit 23f22bc
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion test/common/benchmark.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,27 @@ function runBenchmark(name, args, env) {

const mergedEnv = Object.assign({}, process.env, env);

const child = fork(runjs, argv, { env: mergedEnv });
const child = fork(runjs, argv, { env: mergedEnv, stdio: 'pipe' });
child.stdout.setEncoding('utf8');

let stdout = '';
child.stdout.on('data', (line) => {
stdout += line;
});

child.on('exit', (code, signal) => {
assert.strictEqual(code, 0);
assert.strictEqual(signal, null);
// This bit makes sure that each benchmark file is being sent settings such
// that the benchmark file runs just one set of options. This helps keep the
// benchmark tests from taking a long time to run. Therefore, each benchmark
// file should result in three lines of output: a blank line, a line with
// the name of the benchmark file, and a line with the only results that we
// get from testing the benchmark file.
assert.ok(
/^(?:\n.+?\n.+?\n)+$/.test(stdout),
`benchmark file not running exactly one configuration in test: ${stdout}`
);
});
}

Expand Down

0 comments on commit 23f22bc

Please sign in to comment.