Skip to content

Commit

Permalink
src: remove a stale comment in async_hooks
Browse files Browse the repository at this point in the history
This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: #16318
Refs: #15454 (comment)

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: #43317
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
  • Loading branch information
daeyeon authored and targos committed Jul 31, 2022
1 parent 463f9a6 commit 26e4dc8
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/env-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,6 @@ inline bool AsyncHooks::pop_async_context(double async_id) {

// Ask for the async_id to be restored as a check that the stack
// hasn't been corrupted.
// Since async_hooks is experimental, do only perform the check
// when async_hooks is enabled.
if (UNLIKELY(fields_[kCheck] > 0 &&
async_id_fields_[kExecutionAsyncId] != async_id)) {
FailWithCorruptedAsyncStack(async_id);
Expand Down

0 comments on commit 26e4dc8

Please sign in to comment.