util: improve setting default options

Object.assign is currently very slow. Using Object.keys is much faster in v8 6.3.
nodejs · Dec 30, 2017 · 2721767 · 2721767
1 parent 2d845cf
commit 2721767
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/util.js b/lib/util.js
@@ -317,7 +317,9 @@ Object.defineProperty(inspect, 'defaultOptions', {
     if (options === null || typeof options !== 'object') {
       throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'options', 'Object');
     }
-    Object.assign(inspectDefaultOptions, options);
+    const keys = Object.keys(options);
+    for (var i = 0; i < keys.length; i++)
+      inspectDefaultOptions[keys[i]] = options[keys[i]];
     return inspectDefaultOptions;
   }
 });