Skip to content

Commit

Permalink
test: use string instead of RegExp in split()
Browse files Browse the repository at this point in the history
PR-URL: #13710
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
vsemozhetbyt authored and MylesBorins committed Aug 14, 2017
1 parent 2ef11d5 commit 29141c0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ for (const enc of ['utf8', 'utf16le', 'latin1', 'UTF-8']) {
const headerEnd = received.indexOf('\r\n\r\n', 'utf8');
assert.notStrictEqual(headerEnd, -1);

const header = received.toString('utf8', 0, headerEnd).split(/\r\n/);
const header = received.toString('utf8', 0, headerEnd).split('\r\n');
const body = received.toString(enc, headerEnd + 4);

assert.strictEqual(header[0], 'HTTP/1.1 200 OK');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-repl-setprompt.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ child.stdin.end(`e.setPrompt("${p}");${os.EOL}`);
child.on('close', function(code, signal) {
assert.strictEqual(code, 0);
assert.ok(!signal);
const lines = data.split(/\n/);
const lines = data.split('\n');
assert.strictEqual(lines.pop(), p);
});
2 changes: 1 addition & 1 deletion test/parallel/test-stdin-script-child.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ child.stdout.on('data', function(c) {

child.stderr.setEncoding('utf8');
child.stderr.on('data', function(c) {
console.error(`> ${c.trim().split(/\n/).join('\n> ')}`);
console.error(`> ${c.trim().split('\n').join('\n> ')}`);
});

child.on('close', common.mustCall(function(c) {
Expand Down

0 comments on commit 29141c0

Please sign in to comment.