Skip to content

Commit

Permalink
test: switch to use common.fixtures module for fixturesDir
Browse files Browse the repository at this point in the history
PR-URL: #15821
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
  • Loading branch information
r1cebank authored and gireeshpunathil committed Oct 11, 2017
1 parent 16ed116 commit 2ddb2fa
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions test/parallel/test-tls-connect-given-socket.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,15 @@
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const fixtures = require('../common/fixtures');

const assert = require('assert');
const tls = require('tls');
const net = require('net');
const fs = require('fs');
const path = require('path');

const options = {
key: fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem')),
cert: fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem'))
key: fixtures.readSync('test_key.pem'),
cert: fixtures.readSync('test_cert.pem')
};

const server = tls.createServer(options, common.mustCall((socket) => {
Expand Down

2 comments on commit 2ddb2fa

@Trott
Copy link
Member

@Trott Trott commented on 2ddb2fa Oct 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gireeshpunathil First line of commit message is longer than 50 chars here. (I know a lot of people think that rule shouldn't even exist. This is a totally minor thing. Only noting it because core-validate-commit complains.)

@gireeshpunathil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, thanks @Trott - will take care next time.

Please sign in to comment.