Skip to content

Commit

Permalink
build: add -Werror=undefined-inline to clang builds
Browse files Browse the repository at this point in the history
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information
refack authored and MylesBorins committed Dec 3, 2018
1 parent d82e818 commit 2e83f1e
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions node.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,13 @@
'-Wendif-labels',
'-W',
'-Wno-unused-parameter',
'-Werror=undefined-inline',
],
},
'conditions': [
['clang==1', {
'cflags': [ '-Werror=undefined-inline', ]
}],
[ 'node_shared=="false"', {
'msvs_settings': {
'VCManifestTool': {
Expand Down

1 comment on commit 2e83f1e

@barracuda156
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets pulled in with GCC and breaks the build.

cc1: error: '-Werror=undefined-inline': no option '-Wundefined-inline'; did you mean '-Wundefined-do-loop'?
cc1: warning: '-Werror=' argument '-Werror=extra-semi' is not valid for C

Please sign in to comment.