stream: fix removeAllListeners() for Stream.Readable

Fixes: #20923
nodejs · May 24, 2018 · 30cefde · 30cefde
1 parent 5823938
commit 30cefde
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
@@ -846,7 +846,7 @@ Readable.prototype.removeListener = function(ev, fn) {
 };
 
 Readable.prototype.removeAllListeners = function(ev) {
-  const res = Stream.prototype.removeAllListeners.call(this, ev);
+  const res = Stream.prototype.removeAllListeners.apply(this, arguments);
 
   if (ev === 'readable' || ev === undefined) {
     // We need to check if there is someone still listening to

diff --git a/test/parallel/test-stream-readable-event.js b/test/parallel/test-stream-readable-event.js
@@ -113,3 +113,16 @@ const Readable = require('stream').Readable;
     assert.deepStrictEqual(result, expected);
   }));
 }
+
+{
+  // #20923
+  const r = new Readable();
+  r._read = function() {
+    // actually doing thing here
+  };
+  r.on('data', function() {});
+
+  r.removeAllListeners();
+
+  assert.strictEqual(r.eventNames().length, 0);
+}