stream: make checking pendingcb on WritableStream backward compatible

PR-URL: #54142 Fixes: #54131 Refs: #54131 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
nodejs · Oct 2, 2024 · 337cd41 · 337cd41
1 parent 8fd951f
commit 337cd41
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/internal/streams/end-of-stream.js b/lib/internal/streams/end-of-stream.js
@@ -215,7 +215,7 @@ function eos(stream, options, callback) {
     !readable &&
     (!willEmitClose || isReadable(stream)) &&
     (writableFinished || isWritable(stream) === false) &&
-    (wState == null || wState.pendingcb === 0)
+    (wState == null || wState.pendingcb === undefined || wState.pendingcb === 0)
   ) {
     process.nextTick(onclosed);
   } else if (

diff --git a/test/parallel/test-stream-finished.js b/test/parallel/test-stream-finished.js
@@ -687,3 +687,16 @@ testClosed((opts) => new Writable({ write() {}, ...opts }));
     assert.strictEqual(stream._writableState.pendingcb, 0);
   }));
 }
+
+{
+  const stream = new Duplex({
+    write(chunk, enc, cb) {}
+  });
+
+  stream.end('foo');
+
+  // Simulate an old stream implementation that doesn't have pendingcb
+  delete stream._writableState.pendingcb;
+
+  finished(stream, { readable: false }, common.mustCall());
+}