Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
crypto: remove BIO_set_shutdown
Browse files Browse the repository at this point in the history
I've not been able to find any reason for calling
BIO_set_shutdown(bio, 1). This is done by default for the following
versions of OpenSSL:

https://github.com/openssl/openssl/blob/OpenSSL_1_1_0/
crypto/bio/bio_lib.c#L26

https://github.com/openssl/openssl/blob/OpenSSL_1_0_1/
crypto/bio/bio_lib.c#L90

https://github.com/openssl/openssl/blob/OpenSSL_1_0_2/
crypto/bio/bio_lib.c#L88

https://github.com/openssl/openssl/blob/OpenSSL_1_0_0/
crypto/bio/bio_lib.c#L90

This commit removes the call and the comment.

Backport-PR-URL: #17784
PR-URL: #17542
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danbev authored and MylesBorins committed Jan 17, 2018

Unverified

The email in this signature doesn’t match the committer email.
1 parent 8e89616 commit 3c4bb3c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/node_crypto_bio.cc
Original file line number Diff line number Diff line change
@@ -51,8 +51,6 @@ void NodeBIO::AssignEnvironment(Environment* env) {
int NodeBIO::New(BIO* bio) {
bio->ptr = new NodeBIO();

// XXX Why am I doing it?!
bio->shutdown = 1;
bio->init = 1;
bio->num = -1;

0 comments on commit 3c4bb3c

Please sign in to comment.