Skip to content

Commit

Permalink
tools: implement ninja build with --build-v8-with-gn
Browse files Browse the repository at this point in the history
PR-URL: #19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
hashseed authored and MylesBorins committed Apr 11, 2018
1 parent 3e6ff85 commit 3fb8abf
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,13 @@
'conditions': [
['GENERATOR=="ninja"', {
'obj_dir': '<(PRODUCT_DIR)/obj',
'v8_base': '<(PRODUCT_DIR)/obj/deps/v8/gypfiles/libv8_base.a',
'conditions': [
[ 'build_v8_with_gn=="true"', {
'v8_base': '<(PRODUCT_DIR)/obj/deps/v8/gypfiles/v8_monolith.gen/gn/obj/libv8_monolith.a',
}, {
'v8_base': '<(PRODUCT_DIR)/obj/deps/v8/gypfiles/libv8_base.a',
}],
]
}, {
'obj_dir%': '<(PRODUCT_DIR)/obj.target',
'v8_base': '<(PRODUCT_DIR)/obj.target/deps/v8/gypfiles/libv8_base.a',
Expand Down

0 comments on commit 3fb8abf

Please sign in to comment.