Skip to content

Commit

Permalink
test: remove obsolete debugger tests
Browse files Browse the repository at this point in the history
The tests in `test/debugger` all fail since the removal of the
pre-inspector debugger (if they weren't already failing). They do not
run in CI (probably because they were never reliable). Remove them and
associated fixtures.

PR-URL: #15139
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott authored and jasnell committed Sep 20, 2017
1 parent b58a2aa commit 5125c08
Show file tree
Hide file tree
Showing 14 changed files with 3 additions and 555 deletions.
3 changes: 0 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -386,9 +386,6 @@ test-pummel: all
test-internet: all
$(PYTHON) tools/test.py internet

test-debugger: all
$(PYTHON) tools/test.py debugger

test-inspector: all
$(PYTHON) tools/test.py inspector

Expand Down
6 changes: 3 additions & 3 deletions doc/api/debugger.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,18 +125,18 @@ It is also possible to set a breakpoint in a file (module) that
is not loaded yet:

```txt
$ node inspect test/fixtures/break-in-module/main.js
$ node inspect main.js
< Debugger listening on ws://127.0.0.1:9229/4e3db158-9791-4274-8909-914f7facf3bd
< For help see https://nodejs.org/en/docs/inspector
< Debugger attached.
Break on start in test/fixtures/break-in-module/main.js:1
Break on start in main.js:1
> 1 (function (exports, require, module, __filename, __dirname) { const mod = require('./mod.js');
2 mod.hello();
3 mod.hello();
debug> setBreakpoint('mod.js', 22)
Warning: script 'mod.js' was not loaded yet.
debug> c
break in test/fixtures/break-in-module/mod.js:22
break in mod.js:22
20 // USE OR OTHER DEALINGS IN THE SOFTWARE.
21
>22 exports.hello = function() {
Expand Down
1 change: 0 additions & 1 deletion test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ On how to run tests in this directory, see
|addons |Yes |Tests for [addon](https://nodejs.org/api/addons.html) functionality along with some tests that require an addon to function properly.|
|cctest |Yes |C++ test that is run as part of the build process.|
|common | |Common modules shared among many tests. [Documentation](./common/README.md)|
|debugger |No |Tests for [debugger](https://nodejs.org/api/debugger.html) functionality along with some tests that require an addon to function properly.|
|fixtures | |Test fixtures used in various tests throughout the test suite.|
|gc |No |Tests for garbage collection related functionality.|
|inspector |Yes |Tests for the V8 inspector integration.|
Expand Down
150 changes: 0 additions & 150 deletions test/debugger/helper-debugger-repl.js

This file was deleted.

82 changes: 0 additions & 82 deletions test/debugger/test-debugger-repl-break-in-module.js

This file was deleted.

42 changes: 0 additions & 42 deletions test/debugger/test-debugger-repl-restart.js

This file was deleted.

65 changes: 0 additions & 65 deletions test/debugger/test-debugger-repl-term.js

This file was deleted.

Loading

0 comments on commit 5125c08

Please sign in to comment.